Patrick Lam

Associate Professor, Department of Electrical and Computer Engineering
Director, Software Engineering Programme
University of Waterloo
email: patrick.lam@uwaterloo.ca (no unsolicited commercial email)
phone: use email instead!

Picture of Patrick Lam

Patch: de-lameify evince

May 12, 2008

From: Patrick Lam
To: evince-list@gnome.org
Date: Mon, May 12, 2008 at 7:12 PM
Subject: Patch: do not persist print pages settings, etc.

Hi,

I've been frustrated a number of times by evince's persisting of page
ranges for printing. That is, if I print pages 1-3 of x.pdf, and then
tomorrow I print y.pdf without checking the dialog box, evince happily
prints pages 1-3 of y.pdf. No sane person could want that!

Please consider the following trivial diff, which prevents the
persisting of page information.

Index: shell/ev-application.c
===================================================================
--- shell/ev-application.c      (revision 3031)
+++ shell/ev-application.c      (working copy)
@@ -828,6 +828,12 @@
       if (application->print_settings)
               g_object_unref (application->print_settings);

+       /* Do not persist print pages, page ranges, or page set. */
+       /* (I've wasted too many pages on this. -plam) */
+       gtk_print_settings_set_print_pages(settings, GTK_PRINT_PAGES_ALL);
+       gtk_print_settings_set_page_ranges(settings, NULL, 0);
+       gtk_print_settings_set_page_set(settings, GTK_PAGE_SET_ALL);
+
       application->print_settings = g_object_ref (settings);
 }

Thanks!

pat

Link to this page.

Valid HTML 5!